RFR [12] 8213490: Networking area nano cleanup
Pavel Rappo
pavel.rappo at oracle.com
Tue Nov 13 02:45:27 UTC 2018
> On 13 Nov 2018, at 00:35, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>
> Do you want to change ie. -> i.e. here as well:
>
> src/java.base/windows/native/libnet/net_util_md.c
>
> - * 2. If the reqeusted port is 0 (ie. any port) then we try to bind in v4 space
> + * 2. If the requested port is 0 (ie. any port) then we try to bind in v4 space
Thanks. I have addressed "eg." too, please see the result here:
http://cr.openjdk.java.net/~prappo/8213490/webrev.02/
> And a couple more of duplicate words to remove:
>
> jdk/internal/net/http/Http1AsyncReceiver.java: // If the queue is not empty, wait until it it is empty before
> jdk/internal/net/http/Http2Connection.java: // if true, the the stream may be assigned to this connection
After I have noticed this this pattern [*] I wrote a tiny tool to help me search
for occurrences of it in comments and javadocs. It's just a little bit more
complicated than a bunch of regexes, as javadoc structures (e.g. "{@link method
method}" or "@param number number", etc.) would otherwise yield too many false
positives. Your comment reminded me that I forgot about single-line comments.
The tool has been updated. Thanks.
[*] Pun intended
More information about the net-dev
mailing list