RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

vyom tewari vyom.tewari at oracle.com
Tue Nov 13 12:35:46 UTC 2018


Hi Chris,

Thanks for review, please find the latest 
webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html) 
where i incorporated your suggestion. Now i am returning the different 
error code(-2) if IP Helper Library function GetIfTable fails. I checked 
the all other call sites and we don't need to do any additional changes.

Thanks,

Vyom

On 08/11/18 6:19 PM, Chris Hegarty wrote:
> Hi Vyom,
>
> On 08/11/18 09:22, vyom tewari wrote:
>> Hi,
>>
>> Please review the below code change.
>>
>> Webrev: http://cr.openjdk.java.net/~vtewari/8046500/webrev0.0/index.html
>
> enumInterfaces may return -1 for error conditions other than
> IP Helper Library GetIfTable function failed. I wonder if this
> specific failure should have its own separate return value,
> maybe -2, so as to not be confused with other error conditions?
>
> Similarly enumAddresses_win.
>
> Of course all call sites of these functions will need to be
> checked if this is done, but there are not that many.
>
> -Chris


More information about the net-dev mailing list