RFR [12] 8213490: Networking area nano cleanup

[Ivan Gerasimov]

Thanks Pavel, looks good!

*src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java*

I wonder if 'I' needs to be capitalized, as it starts a sentence:

       * Authenticator for a particular realm is single threaded.
-     * ie. if multiple threads need to get credentials from the user
+     * i.e. if multiple threads need to get credentials from the user
       * at the same time, then all but the first will block until

No need for a separate review, if you agree to change i -> I.

With kind regards,

Ivan


On 11/12/18 6:45 PM, Pavel Rappo wrote:
>> On 13 Nov 2018, at 00:35, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>>
>> Do you want to change  ie. -> i.e.  here as well:
>>
>> src/java.base/windows/native/libnet/net_util_md.c
>>
>> - * 2. If the reqeusted port is 0 (ie. any port) then we try to bind in v4 space
>> + * 2. If the requested port is 0 (ie. any port) then we try to bind in v4 space
> Thanks. I have addressed "eg." too, please see the result here:
>
>    http://cr.openjdk.java.net/~prappo/8213490/webrev.02/
>
>> And a couple more of duplicate words to remove:
>>
>> jdk/internal/net/http/Http1AsyncReceiver.java:        // If the queue is not empty, wait until it it is empty before
>> jdk/internal/net/http/Http2Connection.java:    // if true, the the stream may be assigned to this connection
> After I have noticed this this pattern [*] I wrote a tiny tool to help me search
> for occurrences of it in comments and javadocs. It's just a little bit more
> complicated than a bunch of regexes, as javadoc structures (e.g. "{@link method
> method}" or "@param number number", etc.) would otherwise yield too many false
> positives. Your comment reminded me that I forgot about single-line comments.
> The tool has been updated. Thanks.
>
> [*] Pun intended
>
>

-- 
With kind regards,
Ivan Gerasimov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20181113/ceb79baa/attachment.html>