RFR [12] 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up

Chris Hegarty chris.hegarty at oracle.com
Mon Oct 1 17:08:46 UTC 2018



> On 1 Oct 2018, at 16:42, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Looks good to me.
> 
> Nit indentation at line 142:
> 142             if (!other.connected()) {

Thanks. I’ll fix the before pushing.

-Chris.

> best regards,
> 
> -- daniel
> 
> On 01/10/2018 15:08, Chris Hegarty wrote:
>> Similar to the recent test fix for 8211092 [1], this change proposes to
>> modify the test so that it's main method does not return until all
>> threads, created by the test, terminate. This is important when run in
>> samevm / agentvm mode.
>> The change avoids any potential issues where jtreg may attempt to "clean
>> -up" these threads ( the clean up fails quite often as the closer thread
>> can linger in blocking close ).
>> http://cr.openjdk.java.net/~chegar/8211325.00/index.html
>> -Chris.
>> P.S. I'll fix some of the unrelated indentation issue before pushing,
>> which have been deliberately omitted to avoid confusing the actual
>> changes.
>> [1] https://bugs.openjdk.java.net/browse/JDK-8211092
> 



More information about the net-dev mailing list