RFR: 8189366: SocketInputStream.available() should check for eof

Chris Hegarty chris.hegarty at oracle.com
Wed Oct 10 16:20:47 UTC 2018


Vyom,

On 10/10/18 14:16, vyom tewari wrote:
> Hi All,
> 
> Please provide your review comments on below fix.
> 
> Thanks,
> 
> Vyom
> 
> 
> On Friday 27 October 2017 11:31 AM, vyom tewari wrote:

Wow, is it really almost a year since this was first
discussed!

>>  ...
>>> http://cr.openjdk.java.net/~vtewari/8189366/webrev0.0/index.html 

To satisfy myself, I put together a test, ran it through
Oracle's build and test infra, both with and without your
proposed changes, and it passes ok. This should give more
confidence that there is no inadvertant behavior change
resulting from your changes.

http://cr.openjdk.java.net/~chegar/8189366.test/

Can you please include this test as part of your push?

Thanks,
-Chris.

P.S. The test amends an existing test with additional
coverage, without interfering too much with the original
test.


More information about the net-dev mailing list