RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

[Michael McMahon]

Hi Daniel,

I was allowing for the possibility that the implementation might silently
discard the header. In that case, the server would send the 500 response
after detecting the "Via" header.

- Michael.

On 11/10/2018, 17:32, Daniel Fuchs wrote:
> Hi Michael,
>
> Why the test:
>
>  219             if (response.statusCode() != 200)
>  220                 throw new RuntimeException("illegal header was 
> sent in request");
>
> Shouldn't this always throw, regardless of the status code?
>
> best regards,
>
> -- daniel
>
>
> On 11/10/2018 16:56, Michael McMahon wrote:
>> Thanks Daniel. I updated that test with some new scenarios
>> for end to end testing.
>>
>> http://cr.openjdk.java.net/~michaelm/8203850/webrev.2/
>>
>> Michael
>>
>>
>> On 11/10/2018, 13:58, Daniel Fuchs wrote:
>>> Looks good to me Michael.
>>>
>>> You should be able to easily add new test cases for Origin and
>>> Referer to test/jdk/java/net/SpecialHeadersTest.java too.
>>>
>>> best regards,
>>>
>>> -- daniel
>>>
>>> On 11/10/2018 13:28, Michael McMahon wrote:
>>>> Could I get the following fix reviewed please?
>>>>
>>>> http://cr.openjdk.java.net/~michaelm/8203850/webrev.1/
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>
>