8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

Brian Burkhalter brian.burkhalter at oracle.com
Wed Oct 31 19:20:49 UTC 2018


> On Oct 31, 2018, at 12:16 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 31/10/2018 19:13, Brian Burkhalter wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8213210 <https://bugs.openjdk.java.net/browse/JDK-8213210>
>> 
>> Please see diff included below. CSR to follow.
> One thing to check is whether ServerSocket specifies null handling anywhere. I don't think it does so you might have to add an @throws NPE.

SocketImpl.serServerSocket() cannot throw NPE so I don’t see that the updated ctor can throw it either:

    void setServerSocket(ServerSocket soc) {
        this.serverSocket = soc;
    }

-    ServerSocket(SocketImpl impl) {
+    protected ServerSocket(SocketImpl impl) {
         this.impl = impl;
         impl.setServerSocket(this);
     }

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20181031/c3175fa2/attachment.html>


More information about the net-dev mailing list