RFR of JDK-8210802,temp files left by tests in jdk/java/net/httpclient

[Langer, Christoph]

Hi Hamlin,

no, I don't insist. You should probably wait for another review from some of the folks that are more experienced with the http client and its testing, though.

Best regards
Christoph

> -----Original Message-----
> From: Hamlin Li <huaming.li at oracle.com>
> Sent: Montag, 17. September 2018 11:02
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: OpenJDK Network Dev list <net-dev at openjdk.java.net>
> Subject: Re: RFR of JDK-8210802,temp files left by tests in
> jdk/java/net/httpclient
> 
> Hi Christoph,
> 
> Thank you for review.
> 
> Normally I prefer to use "finally" too.
> 
> But for this case, it's simpler to use deleteOnExit(), and for
> TestUtil.java and Driver.java it can not use "finally", because the temp
> files will be used outside of methods.
> 
> If you insist on "finally" I can modify them except of TestUtil.java and
> Driver.java.
> 
> Thank you
> 
> -Hamlin
> 
> 
> On 2018/9/17 4:25 PM, Langer, Christoph wrote:
> > Hi Hamlin,
> >
> > wouldn't it be better/cleaner to move the deletion of files into finally
> blocks? But I guess one can do it with deleteOnExit() as well...
> >
> > Best regards
> > Christoph
> >
> >> -----Original Message-----
> >> From: net-dev <net-dev-bounces at openjdk.java.net> On Behalf Of
> Hamlin Li
> >> Sent: Montag, 17. September 2018 07:55
> >> To: OpenJDK Network Dev list <net-dev at openjdk.java.net>
> >> Subject: RFR of JDK-8210802,temp files left by tests in
> jdk/java/net/httpclient
> >>
> >> Would you please review the following patch?
> >>
> >> bug: https://bugs.openjdk.java.net/browse/JDK-8210802
> >> webrev: http://cr.openjdk.java.net/~mli/8210802/webrev.00/
> >>
> >> Thank you
> >> -Hamlin