[ipv6] Regarding 8220673: Add test library support for determining platform IP support
Arthur Eubanks
aeubanks at google.com
Wed Apr 10 17:51:08 UTC 2019
>
> There are a bunch of tests with "-Djava.net.preferIPv4Stack=true", which
> should clearly fail in an IPv6 only environment.
>
>
> Right.
>
> Would skipping these when IPv4 is not supported be okay?
>
>
> Yes, I believe so, but we will need to check what specific functionality
> that the test is exercising. In many cases it's just the TCP/UDP stack
> without IPv6 support, to exercise more code paths. These cases should be
> fine to be excluded for IPv6-only environments.
>
> I'll play a little with the jtreg @requires functionality, but depending
> on the test structure and the existing @run tags, it may be more
> straight forward to just check for the presence of the system property
> and platform support ( wrapped up into a convenient test library
> function ), returning early from the test where it doesn't make sense to
> run on that configuration.
>
So at the beginning of each networking test that tests multiple
configurations, there is something like `if
(IPSupport.currentConfigurationNotSupported()) { return; }`?
That seems slightly ugly, but maybe that's the best way.
>
> I see that some tests with "-Djava.net.preferIPv6Addresses=true" will pass
> even if the IPv6 part of the test failed.
>
>
> Do you have a list of these?
>
test/jdk/java/nio/channels/DatagramChannel/BindNull.java is the only one I
see.
>
>
> On Fri, Mar 29, 2019 at 12:59 PM Arthur Eubanks <aeubanks at google.com>
> wrote:
>
>> ... Also, we don't have a JDK at head which works in our environments, so
>> we might miss some failures until we've decided to have a JDK at head that
>> works in our environments and run all of the networking tests.
>>
>
> Right, there is a chicken and egg problem here, but you are correct that
> we need to make progress on an IPv6-only JDK build. If not yet
> integrated, at least a generally agreed patch / approach.
>
> -Chris.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190410/e175c1d5/attachment.html>
More information about the net-dev
mailing list