[ipv6] Regarding 8220673: Add test library support for determining platform IP support

Daniel Fuchs daniel.fuchs at oracle.com
Thu Apr 11 13:05:13 UTC 2019


Hi Arthur,

This looks like a good cleanup to me.

On 10/04/2019 21:39, Arthur Eubanks wrote:
> Here's a prototype webrev to see if the approach is okay with you. If it 
> looks good, I'll continue with the remaining tests I can find. (should I 
> start a new thread for the webrev?)
> 
> http://cr.openjdk.java.net/~aeubanks/8220673/webrev.00

DatagramChannel/BindNull.java

   48         if (IPSupport.hasIPv4()) {
   49             try (DatagramChannel dc = 
DatagramChannel.open(StandardProtocolFamily.INET6)) {
   50                 dc.bind(null);
   51             }
   52         }

I guess you meant `IPSupport.hasIPv6()` here?

We're putting a lot of trust in the implementation of this
IPSupport utility.

Have you been able to verify visually - by looking at the
tests logs and trying out different configuration on your
local machine - that it is behaving as expected?

best regards,

-- daniel


More information about the net-dev mailing list