[ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

[Daniel Fuchs]

Hi Arthur,

The jdk.changeset file in your webrev looks completely wrong.
http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.02/jdk.changeset
I assume it's just garbage and we should ignore it.
Can you confirm?

WRT to the individual files changes listed at
http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.02/index.html

In unix/native/libnet/net_util_md.c ipv4_supported():

I was wondering if we should be more selective about
what kind of errors we should consider meaning that
IPv4 is not available. But given that this method
executes in OnLoad and that there is a precedent with
ipv6_supported() I believe that what you have is fine.

The rest looks very reasonable to me.

Could you try to fix the jdk.changeset in the webrev so that we
could try to import and test your proposed changes?

best regards,

-- daniel

On 23/04/2019 16:54, Arthur Eubanks wrote:
>     I believe that `DONT_ENABLE_IPV4`is not strictly required. Maybe just
>     drop it?  Is it an initial attempt to support an IPv6-only JDK build?
>     If so, then maybe we separate out that requirement.
> 
> It was in the IPv6 code right below so I just copied it in case we 
> wanted an IPv6-only build at some point. But yes that can be in a 
> separate change. Removed.
> New webrev:
> http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.02/index.html