RFR: 8129315: java/net/Socket/LingerTest.java and java/net/Socket/ShutdownBoth.java timeout intermittently

[Chris Hegarty]

Daniel,

On 26/04/2019 14:33, Daniel Fuchs wrote:
> Hi,
> 
> Please find below a test stabilization fix for:
> 
> 8129315: java/net/Socket/LingerTest.java and
>           java/net/Socket/ShutdownBoth.java timeout intermittently
> http://cr.openjdk.java.net/~dfuchs/webrev_8129315/webrev.00/index.html

This looks good.

> While testing I stumbled on some other tests failing
> intermittently for the fame reasons and went ahead and
> fixed some of them too. Tests fixed in this batch:
> 
> test/jdk/java/net/Socket/LingerTest.java
> test/jdk/java/net/Socket/ShutdownBoth.java
> test/jdk/java/net/Socks/SocksIPv6Test.java
> test/jdk/sun/net/www/http/HttpURLConnection/PostOnDelete.java
> 
> The crux of the issue is that using the wildcard address to
> bind test servers makes them susceptible of receiving traffic from
> other processes/tests on the same machine, and make them also
> susceptible of not receiving traffic that was intended for them,
> if some other process has managed to bind on a specific address
> with the same port number.
> 
> I have started a longer background investigation task to identify
> and fix the other tests that may present the same symptoms, so
> more RFRs like this one will probably come in the future.

Good strategy, small(ish) incremental improvements are easier
to review and improve test stability in a more timely manner.

-Chris.