RFR 8216978: Drop support for pre JDK 1.4 SocketImpl implementations

[Michael McMahon]

Thanks Chris. Comments noted.

- Michael

On 29/04/2019, 11:26, Chris Hegarty wrote:
> Michael,
>
> On 29/04/2019 10:52, Michael McMahon wrote:
>> Hi,
>>
>> This is another change which is part of the general cleanup of 
>> SocketImpls.
>> The change removes support for pre JDK 1.4 socketimpls which do not 
>> implement
>> the timed connect method. These SocketImpls have not been compilable
>> since 1.4 and limited runtime support has been provided since then, 
>> which is now being removed.
>>
>> Webrev
>> -------
>> http://cr.openjdk.java.net/~michaelm/8216978/webrev.1/
>
> Mostly looks good. A few specific comments:
>
> Socket.java
>  Please remove these comments, as they are no longer applicable:
>
>  1675         // Before 1.3 Sockets were always connected during creation
>  1692         // Before 1.3 Sockets were always bound during creation
>
> ServerSocket.java
>  Please remove:
>   75      * Are we using an older SocketImpl?
>   76      */
>   77     private boolean oldImpl = false;
>  And there is still one reference to it:
>   347         if (!oldImpl && isBound())
>
> SocketImpl.java
>  Please remove:
>   Defaults to false, unless setIsServer() called
>   79      * from ServerSocket
>
> -Chris.