RFR: 8228970: AssertionError in ResponseSubscribers$HttpResponseInputStream

[Patrick Concannon]

Hi,

Please find a link to the updated webrev below:

http://cr.openjdk.java.net/~dfuchs/pconcann/8228970/webrevs/webrev.3/


Kind regards,

Patrick


On 06/08/2019 12:08, Patrick Concannon wrote:
> Hi,
>
> Thanks for the feedback, Pavel. I'll make that switch now!
>
> Kind regards,
>
> Patrick
>
> On 06/08/2019 11:31, Pavel Rappo wrote:
>> May I suggest using org.testng.Assert.assertThrows instead of 
>> hand-rolled
>> try-catch constructs in the test?
>>
>>> On 6 Aug 2019, at 11:12, Patrick Concannon 
>>> <patrick.concannon at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> Would it be possible to have my fix for JDK-8228970 reviewed?
>>>
>>> The fix modifies the read(byte[], int, int) method from 
>>> ResponseSubscribers$HttpResponseInputStream adding further checks 
>>> for bad parameters. I've also added an additional test case that 
>>> ensures that these checks are being met.
>>>
>>> Further information on this bug can be found here: 
>>> https://bugs.openjdk.java.net/browse/JDK-8228970
>>>
>>> Webrev for fix: 
>>> http://cr.openjdk.java.net/~dfuchs/pconcann/webrev_8228970/webrev.2/
>>>
>>>
>>> Kind regards,
>>>
>>> Patrick
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190807/ff8f95b9/attachment.html>