RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Daniel Fuchs daniel.fuchs at oracle.com
Fri Aug 9 13:30:27 UTC 2019


Hi Julia,

On 09/08/2019 13:40, Julia Boes wrote:
> Hi,
> 
> Please find an alternative fix below. Chris and Daniel suggested to add 
> a new method MessageHeader::isRequestline rather than a separate data 
> field for the requestline. A whitebox test was added with the method 
> testMessageHeader.
> 
> Updated webrev: 
> http://cr.openjdk.java.net/~michaelm/jboes/8185898/webrev.4/

Thanks for doing this! This new approach seems safer to
me as it's less likely to cause compatibility issue with
code that might be using MessageHeader elsewhere.

Make sure to test thoroughly though! :-)

best regards,

-- daniel

> 
> Regards,
> 
> Julia


More information about the net-dev mailing list