RFR(XS): 8228508: [TESTBUG] java/net/httpclient/SmokeTest.java fails on Windows7

[Aleks Efimov]

Hi Daniel, Chris,

The second version of the fix that addresses your on-line and off-line 
suggestions and comments could be viewed here:
http://cr.openjdk.java.net/~aefimov/8228508/01/

Summary of the changes:
1. Usages of com/sun/net/httpserver/EchoHandler were replaced with newly 
added SmokeTest.HttpEchoHandler static class.
2. Added checks for 'content-length' and 'transfer-encoding' header 
values to assert the test mechanics
3. server.EchoHandler has been fixed to read-off the request body + 
minor improvements

Testing:
1. Modified SmokeTest was launched on Windows 7 platform with 
SmokeTest.HttpEchoHandler and with com/sun/net/httpserver/EchoHandler - 
in both cases no failures observed.
2. jdk_net tests set was executed on all platforms - no failures.

With Best Regards,
Aleksei


On 07/08/2019 12:42, Chris Hegarty wrote:
>
>
> On 07/08/2019 11:40, Daniel Fuchs wrote:
>> Hi Aleksei,
>>
>> If there is a bug with the com/sun/net/httpserver/EchoHandler.java
>> class I'd rather fix that rather than use the
>> java/net/httpclient/EchoHandler.java.
>
> Maybe we can do both?
>
> Changing the com.sun EchoHandler may impact other tests in
> the com.sun area, so such a change will need more extensive
> testing.
>
> -Chris.