RFR(XS): 8228508: [TESTBUG] java/net/httpclient/SmokeTest.java fails on Windows7

[Daniel Fuchs]

Looks fine to me Aleksej.

The new assert will fire only if the test is run with -ea, but
that's the default in our CI (and they're new additional checks
anyway which the test doesn't strictly requires) so I think
that's OK.

best regards,

-- daniel

On 12/08/2019 18:14, Aleks Efimov wrote:
> Hi Daniel, Chris,
> 
> The second version of the fix that addresses your on-line and off-line 
> suggestions and comments could be viewed here:
> http://cr.openjdk.java.net/~aefimov/8228508/01/
> 
> Summary of the changes:
> 1. Usages of com/sun/net/httpserver/EchoHandler were replaced with newly 
> added SmokeTest.HttpEchoHandler static class.
> 2. Added checks for 'content-length' and 'transfer-encoding' header 
> values to assert the test mechanics
> 3. server.EchoHandler has been fixed to read-off the request body + 
> minor improvements
> 
> Testing:
> 1. Modified SmokeTest was launched on Windows 7 platform with 
> SmokeTest.HttpEchoHandler and with com/sun/net/httpserver/EchoHandler - 
> in both cases no failures observed.
> 2. jdk_net tests set was executed on all platforms - no failures.
> 
> With Best Regards,
> Aleksei