RFR 8078219: Verify lack of @test tag in files in java/net test directory

[Patrick Concannon]

Hi,

Thanks Alan for the suggestions. I've made those changes below:

http://cr.openjdk.java.net/~aefimov/pconcann/8078219/01/


Kind regards,

Patrick


On 20/08/2019 15:44, Alan Bateman wrote:

>
>
> On 20/08/2019 15:27, Patrick Concannon wrote:
>> Hi,
>>
>>
>> Would it be possible to have my fix for JDK-8078219 reviewed?
>>
>> Several tests in java.net were found to be missing their JTReg @test 
>> tags:
>>
>>  1. test/jdk/java/net/MulticastSocket/Reuse.java -- Test tag added.
>>     Test worked as expected
>>  2. test/jdk/java/net/URLClassLoader/GetURLsTest.java -- Test tag
>>     added. Fix was required.
>>  3. test/jdk/java/net/MulticastSocket/MulticastAddresses.java -- Test
>>     tag added. Fix was required.
>>
>> Further information on this bug can be found here: 
>> https://bugs.openjdk.java.net/browse/JDK-8078219
>>
>> Webrev for fix: http://cr.openjdk.java.net/~aefimov/pconcann/8078219/00/
>>
> I assume GetURLsTest also needs a @summary tag for the text in the 
> test description.
>
> In MulticastAddresses it might be better to reformat L39 to avoid the 
> excessively long line (really long lines can be annoying when looking 
> at side-by-side diffs). Also we should rename non_multicastsXXXX 
> fields while we are there as they are inconsistent with everything 
> else in this area.
>
> -Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190821/cd4f5240/attachment.html>