RFR: 8230000: some httpclients testng tests run zero test
Julia Boes
julia.boes at oracle.com
Mon Aug 26 11:09:55 UTC 2019
Thanks for catching that, Aleksei!
Updated webrev:
http://cr.openjdk.java.net/~dfuchs/jboes/8230000/webrev.02/index.html
Cheers,
Julia
On 23/08/2019 18:52, Daniel Fuchs wrote:
> Oh! Good catch Aleksei!
>
> In fact all three files are missing the comma.
>
> cheers,
>
> -- daniel
>
> On 23/08/2019 18:47, Aleks Efimov wrote:
>> Hi Julia,
>>
>> Minor comments:
>> test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2:
>> Could you please add the missing comma after the last modification
>> year, i.e. "2018, 2019,"
>>
>> test/jdk/java/net/httpclient/LineSubscribersAndSurrogatesTest.java#2:
>> Same stuff: "2018, 2019,"
>>
>> Otherwise looks good to me
>>
>> With Best Regards,
>> Aleksei
>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8230000
>>>
>>> Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8230000/webrev.01/
>>>
More information about the net-dev
mailing list