RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines

Baesken, Matthias matthias.baesken at sap.com
Tue Aug 27 07:43:55 UTC 2019


Thanks for the reviews .  I removed the comment and pushed the change .

Best regards, Matthias

> -----Original Message-----
> From: Langer, Christoph
> Sent: Montag, 26. August 2019 16:10
> To: Chris Hegarty <chris.hegarty at oracle.com>; Baesken, Matthias
> <matthias.baesken at sap.com>
> Cc: net-dev at openjdk.java.net
> Subject: RE: RFR [XS] : 8229706:
> java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX
> machines
> 
> Hi Matthias,
> 
> looks good to me, too. And +1 for dropping the comment.
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: net-dev <net-dev-bounces at openjdk.java.net> On Behalf Of Chris
> > Hegarty
> > Sent: Freitag, 16. August 2019 13:44
> > To: Baesken, Matthias <matthias.baesken at sap.com>
> > Cc: net-dev at openjdk.java.net
> > Subject: Re: RFR [XS] : 8229706:
> > java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX
> > machines
> >
> >
> > > On 16 Aug 2019, at 10:51, Baesken, Matthias
> <matthias.baesken at sap.com>
> > wrote:
> > >
> > > Thanks alot !
> > >
> > > I guess I can push  this as  trivial (but a second reviewer would be good
> too
> > ).
> >
> > The change looks fine.
> >
> > You could probably drop the comment, I don’t think that
> > it’s really needed.
> >
> > > Best regards, Matthias
> > >
> > >> -----Original Message-----
> > >> From: Daniel Fuchs <daniel.fuchs at oracle.com>
> > >> ...
> > >>
> > >> I haven't observed any failures over 50 runs on all
> > >> platforms tested. macosx is problem listed for this
> > >> test so it wasn't run there - but all others platforms
> > >> passed with your changes.
> >
> > The set of checks in the NetworkConfiguration for
> > has_testableipv6address could probably be expanded to
> > include macOS. The maybe the test could be removed
> > from the ProblemList ( for mac ). But that is a separate
> > issue, for a follow-on, verification, testing, etc.
> >
> > -Chris.


More information about the net-dev mailing list