RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage
Jaikiran Pai
jai.forums2013 at gmail.com
Thu Aug 29 04:06:48 UTC 2019
On 29/08/19 9:12 AM, Jaikiran Pai wrote:
> Hello Daniel,
>
> On 28/08/19 8:45 PM, Daniel Fuchs wrote:
>> Hi Jaikiran,
>>
>> On 28/08/2019 15:47, Jaikiran Pai wrote:
>>> Can I please get a review and a sponsor for the patch for
>>> https://bugs.openjdk.java.net/browse/JDK-8230310? The patch is hosted as
>>> a webrev at [1].
>> AFAICS your webrev looks fine, but could you try to write a test
>> for that?
> I checked for existing tests to see if I could add something to them but
> couldn't find any, so (lazily) decided not to attempt a new one :)
Turns out my search terms weren't accurate and I now find some Socks
test within the testsuite.
-Jaikiran
More information about the net-dev
mailing list