RFR: 8235141: Specify the required standard socket options for the socket types in the java.net package

[Daniel Fuchs]

Thanks for the review Alan!

new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.01/

On 02/12/2019 15:53, Alan Bateman wrote:
>> 8235141: Specify the required standard socket options for the
>>          socket types in the java.net package
>> https://bugs.openjdk.java.net/browse/JDK-8235141
>>
>> webrev:
>> http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.00/
> A few suggestion for wording:
> 
> "offers some convenience methods to get and set some commonly used options"
> -> "defines convenience methods to set and get several socket options".

Done.

> 
> "However, socket options can be more generally configured using the 
> setOption method"
> -> "This class also defines the setOption and getOption methods to set 
> and query socket options".

Done.

> 
> The tables looks right.
> 
> The RequiredOptions appears to overlap significantly with existing 
> tests, e.g. test/jdk/java/nio/channels already has a SocketOptionTests 
> test for each of the network channel types.

It's true that there might be some overlap. This test is more about
proving consistency between the doc and the different implementations
provided by the JDK. It's too easy for something to fall through the
gaps otherwise.

best regards,

-- daniel

> 
> -Alan