RFR: 8235141: Specify the required standard socket options for the socket types in the java.net package

[Chris Hegarty]

On 03/12/2019 16:39, Daniel Fuchs wrote:
> Thanks for the review Alan!
> 
> new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.01/

Looks good to me.


On 03/12/2019 21:19, Alan Bateman wrote:> On 03/12/2019 16:39, Daniel 
Fuchs wrote:
 >>...
 >
 > I guess the test is okay but it's not really the location to test that
 > the implementations of NetworkChannel support the socket options that
 > they specify. The tests in nio/channels already do this, additionally
 > testing extended socket options.

It is important that this newly specified java.net-socket types 
options-set is tested, to give certainty that the socket implementations 
in the JDK, including the channel adapters, adhere to the specification 
changes proposed here ( nothing more ). I'm ok if the channels part of 
the test is dropped.

-Chris.