RFR 8235413: com.sun.net.httpserver.BasicAuthenticator.charset is protected field

Chris Hegarty chris.hegarty at oracle.com
Thu Dec 5 15:44:53 UTC 2019


> On 5 Dec 2019, at 15:44, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
> 
> Hi,
> 
> Could I get the following trivial fix reviewed please. It is included in diff form below.
> 
> The problem was that a field "charset" was added as part of JDK-8199849, but it  was
> made protected by mistake instead of private. The fix just makes it private.
> 
> There is no regression test for this issue, but the tests for 8199849 all pass with the change
> 
> Thanks,
> 
> Michael
> 
> --o--
> 
> diff -r 636d71e53732 src/jdk.httpserver/share/classes/com/sun/net/httpserver/BasicAuthenticator.java
> --- a/src/jdk.httpserver/share/classes/com/sun/net/httpserver/BasicAuthenticator.java Wed Dec 04 10:26:32 2019 +0100
> +++ b/src/jdk.httpserver/share/classes/com/sun/net/httpserver/BasicAuthenticator.java Thu Dec 05 15:19:49 2019 +0000
> @@ -40,7 +40,7 @@
>  public abstract class BasicAuthenticator extends Authenticator {
> 
>      protected final String realm;
> -    protected final Charset charset;
> +    private final Charset charset;
>      private final boolean isUTF8;
> 
>      /**
> 
LGTM.

-Chris.


More information about the net-dev mailing list