RFR[8233191]: MulticastSocket joinGroup/leaveGroup do not specify their behavior when the outgoing interface has not been set

Alan Bateman Alan.Bateman at oracle.com
Thu Dec 5 16:14:39 UTC 2019


On 05/12/2019 15:50, Patrick Concannon wrote:
> Hi,
>
>
> Could some please review my fix for issue JDK-8233191 'MulticastSocket 
> joinGroup/leaveGroup do not specify their behavior when the outgoing 
> interface has not been set'?
>
> This javadoc fix clarifies the behaviour of 2-arg joinGroup/leaveGroup 
> methods when null is passed for the NetworkInteface argument. The fix 
> also clarifies what is returned by getInterface() and 
> getNetworkInterface() methods when no previous NetworkInterface has 
> been set.
>
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8233191
> webrev: http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.00/
Looks good, just a minor comment that "If <i>null<i> is given and no 
interface ..." might be a bit better "If {@code null}, and no interface 
..." but what you have is okay too.

-Alan.


More information about the net-dev mailing list