RFR[8233191]: MulticastSocket joinGroup/leaveGroup do not specify their behavior when the outgoing interface has not been set

Chris Hegarty chris.hegarty at oracle.com
Thu Dec 5 16:32:59 UTC 2019



> On 5 Dec 2019, at 15:50, Patrick Concannon <patrick.concannon at oracle.com> wrote:
> 
> Hi,
> 
> 
> Could some please review my fix for issue JDK-8233191 'MulticastSocket joinGroup/leaveGroup do not specify their behavior when the outgoing interface has not been set'?
> 
> This javadoc fix clarifies the behaviour of 2-arg joinGroup/leaveGroup methods when null is passed for the NetworkInteface argument. The fix also clarifies what is returned by getInterface() and getNetworkInterface() methods when no previous NetworkInterface has been set.
> 
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8233191
> webrev: http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.00/


Looks good Patrick.

I see that there is already a test in jdk/java/net/NetworkInterface/NoSetNetworkInterface.java, that covers the new spec clarification for getNetworkInterface.


-Chris.


More information about the net-dev mailing list