RFR[8233191]: MulticastSocket joinGroup/leaveGroup do not specify their behavior when the outgoing interface has not been set

Patrick Concannon patrick.concannon at oracle.com
Fri Dec 6 10:01:30 UTC 2019


Hi Alan,


Ah OK. I didn't spot that in your original email. Yeah that seems like 
more concise way to put it.

I've made that change now, and updated the previous webrev.

http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.01/


Kind regards,

Patrick


On 05/12/2019 17:39, Alan Bateman wrote:
> On 05/12/2019 17:17, Patrick Concannon wrote:
>> Hi,
>>
>> Thanks for the feedback. I've made those changes now, and you can 
>> find them in the new webrev below.
>>
>> http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.01/
> I should have been clearer, my comment wasn't about replacing 
> <i>null</i> with {@code null} (but that change is welcome) but a minor 
> tweak to the wording to drop "is given" and replace it with a comma. 
> This would give you "If null, and the network interface is not set, 
> ...". Feel feel to ignore of course.
>
> -Alan


More information about the net-dev mailing list