RFR[8234148]: DatagramSocket.setOption/getOption/supportedOption should support multicast options

[Patrick Concannon]

Hi Daniel,


Well spotted.

I've updated that now, and you can find the changes in the new updated 
webrev below.

http://cr.openjdk.java.net/~pconcannon/8234148/webrevs/webrev.01/


Kind regards,

Patrick


On 05/12/2019 16:01, Daniel Fuchs wrote:
> This looks good to me Patrick.
> With this fix multicast socket options can be set on DatagramSocket,
> except on windows when the DualStackPlainDatagramSocketImpl is used.
>
> DualStackPlainDatagramSocketImpl.java:
>
>  246         if (isReusePortAvailable())
>  247             options.add(StandardSocketOptions.SO_REUSEPORT);
>
> I believe you can remove these two lines as SO_REUSEPORT
> is obviously not supported as per line 215.
>
> best regards,
>
> -- daniel
>
> On 05/12/2019 15:41, Patrick Concannon wrote:
>> Hi,
>>
>>
>> Could some please review my fix for issue JDK-8234148 
>> 'DatagramSocket.setOption/getOption/supportedOption should support 
>> multicast options'?
>>
>> DatagramSocket can be used to send multicast datagrams but it isn't 
>> possible to set multicast options on it. This fix adds multicast 
>> socket options to DatagramSocket.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8234148
>>
>> webrev: 
>> http://cr.openjdk.java.net/~pconcannon/8234148/webrevs/webrev.00/
>>
>> Kind regards,
>>
>> Patrick
>>
>