RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

Daniel Fuchs daniel.fuchs at oracle.com
Mon Dec 16 19:27:56 UTC 2019


Hi Kiran,

1844         if (result == 0)
1845             return true;
1846         else
1847             return false;

could maybe be simplified into:

    return result == 0;


1925                 if (s.indexOf('%') < 0) {
1926                     return s.compareTo(t);
1927                 }

Maybe I'd move that before line 1921

best regards,

-- daniel


On 16/12/2019 16:54, Kiran Ravikumar wrote:
> Thanks Daniel and Chris,
> 
> 
> Here is my updated webrev with the mentioned corrections.
> 
> 
> http://cr.openjdk.java.net/~kravikumar/5064980/webrev.01/
> 
> 



More information about the net-dev mailing list