RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

[Chris Hegarty]

> On 20 Dec 2019, at 20:17, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> ...
> This looks okay to me. There are a few inconsistencies in this code in that some places it checks if fd1 >= 0, others != -1 but I don't think there are correctness issues. You probably don't need to check ipv6_supported as fd1 can't be valid if IPv6 is disabled but won't change the branches that are executed.
> 
> In passing, the pre-existing comment at L1881 in this patch doesn't look right. The index will be 0 when an outgoing interface is not set.
> 

Thanks Alan,

1) I updated the file descriptor check from ` > 0` to ` >= 0`
2) Removed the pre-existing incorrect comment, and
3) Added a few more test scenarios that check the index = 0 cases

Updated webrev:
  https://cr.openjdk.java.net/~chegar/8236441/webrev.01/

-Chris.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20191220/d3afc1a1/attachment.htm>