RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

Chris Hegarty chris.hegarty at oracle.com
Sat Dec 21 09:27:31 UTC 2019


> On 21 Dec 2019, at 08:23, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 20/12/2019 22:34, Chris Hegarty wrote:
>> 
>> Thanks Alan,
>> 
>> 1) I updated the file descriptor check from ` > 0` to ` >= 0`
>> 2) Removed the pre-existing incorrect comment, and
>> 3) Added a few more test scenarios that check the index = 0 cases
>> 
>> Updated webrev:
>> https://cr.openjdk.java.net/~chegar/8236441/webrev.01/
>> 
> The implementation changes and the test looks good.

Thanks for the review.

> It's very platform specific as to whether multicast datagrams can be received when bound to a specific address so I assume this is why this issue could have existed for a long time without being noticed. 

Yes, I think so.

> The "compare against" line  in the webrev looks like it's for jdk/jdk but I assume it is for jdk/jdk14, the changes are good for both.

Right, the change is destined for jdk/jdk14, initially.

-Chris.



More information about the net-dev mailing list