RFR 8216355: missing NULL checks in libnet in interface iteration and potential resource leak in getMacAddress
Baesken, Matthias
matthias.baesken at sap.com
Wed Jan 9 08:36:21 UTC 2019
Hello, please review the following fix .
In NetworkInterface.c and Inet6AddressImpl.c we have some coding that omits checking for ifa_addr == NULL when iterating on the result of the getifaddrs call.
This is similar to what has been fixed in hotspot with
https://bugs.openjdk.java.net/browse/JDK-8208676
The issues are in the bsd/macOS coding. However bsd/macOS also document that ifa_addr can be NULL in special cases (not sure how likely it is to see it "in the wild").
See
https://www.freebsd.org/cgi/man.cgi?getifaddrs
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/getifaddrs.3.html
Additionally a small resource leak in NetworkInterface.c is fixed.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8216355
http://cr.openjdk.java.net/~mbaesken/webrevs/8216355.1/
Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190109/dadb4988/attachment.html>
More information about the net-dev
mailing list