RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

[Steve Groeger]

Hi Chris,

Looks OK to me.

That is one of the changes I had made locally while investigating  
https://bugs.openjdk.java.net/browse/JDK-8207404, so happy to accept it.

Thanks
Steve Groeger
IBM Runtime Technologies
Hursley, Winchester
Tel: (44) 1962 816911  Mobex: 279990  Mobile: 07718 517 129
Fax (44) 1962 816800
Lotus Notes: Steve Groeger/UK/IBM
Internet: groeges at uk.ibm.com

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From:   "Langer, Christoph" <christoph.langer at sap.com>
To:     "net-dev at openjdk.java.net" <net-dev at openjdk.java.net>
Date:   17/01/2019 09:55
Subject:        RFR(XS): 8217311: Improve Exception thrown when 
MulticastSocket.setInterface fails on AIX(Unix)
Sent by:        "net-dev" <net-dev-bounces at openjdk.java.net>



Hi,
 
please help to review a tiny fix.
 
While working on the issue with the AIX multicast tests (
https://bugs.openjdk.java.net/browse/JDK-8207404), I found a place where a 
SocketException thrown in a specific error case could be improved. There 
already exists code to throw a SocketException with the text 
"IPV6_MULTICAST_IF failed (interface has IPv4 address only?) " when 
setsockopt(IPV6_MULTICAST_IF) fails with EINVAL. On AIX, when you have 
IPv4 addresses only on an interface, you’ll run into when setting the 
option on an AF_INET6 socket. So that specific SocketException text would 
match very well then. I guess the addition is fine to be platform 
independent. At best on other platforms EADDRNOTAVAIL is never seen at 
that place. Or if it was, it would certainly have to do with an IP address 
problem on the interface...
 
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8217311.0/ 
Bug: https://bugs.openjdk.java.net/browse/JDK-8217311 
 
Thanks and best regards
Christoph
 


Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190117/9c7f528b/attachment-0001.html>