8217451: ExtendedSocketOptions should encapsulate support for SO_FLOW_SLA

Michael McMahon michael.x.mcmahon at oracle.com
Mon Jan 21 18:00:22 UTC 2019


Hi Alan,

Looks fine apart from extra space on line 85: ExtendedSocketOptions.java

- Michael.

On 21/01/2019, 17:41, Alan Bateman wrote:
> ExtendSocketOptions is the supporting class that the socket 
> implementations use for JDK-specific socket options. Vyom improved it 
> last year to select options based on the socket type but more is 
> needed to handle socket options that are specific to connecting or 
> listening sockets. As things stand, the Solaris specific SO_FLOW_SLA 
> option is the only one with this complication and it is currently 
> special cased by PlainSocketImpl. I want to push this special casing 
> to ExtendSocketOptions so that the special handing is in one place.
>
> The proposed changes are here:
>   http://cr.openjdk.java.net/~alanb/8217451/webrev/index.html
>
> -Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190121/f83397e0/attachment.html>


More information about the net-dev mailing list