RFR: 8217264: HttpClient: Blocking operations in mapper function do not work as documented

Chris Hegarty chris.hegarty at oracle.com
Thu Jan 24 10:50:22 UTC 2019


Daniel,

On 23/01/2019 11:10, Daniel Fuchs wrote:
> Hi,
> 
> Please find below a fix for:
> 
> 8217264: HttpClient: Blocking operations in mapper function do not
>           work as documented
> [1] https://bugs.openjdk.java.net/browse/JDK-8217264
> 
> webrev:
> [2] http://cr.openjdk.java.net/~dfuchs/webrev_8217264/webrev.00/

I agree with the approach, and the changes look good ( in
fact less invasive that I expected ). Thanks for adding
such a comprehensive test, it gives confidence that things
are operating as expected.

I also agree with updating the example in the API
documentation. It should not promote blocking in the
mapper function. I look forward to reviewing that change
too.

-Chris.


More information about the net-dev mailing list