RFR [13] 8217429: WebSocket over authenticating proxy fails to send Upgrade headers

[Chris Hegarty]

Pavel,

> On 25 Jan 2019, at 15:16, Pavel Rappo <pavel.rappo at oracle.com> wrote:
> 
> Chris, thanks for doing this! I have two questions on this change.
> 
> 1. After this change has been applied, there will be a circular dependency
> between HttpRequestImpl and OpeningHandshake. If this code is used by these two
> classes maybe we are better off extracting it into some (already existing) third
> class?

I moved the code to common.Utils, to avoid any unnecessary dependency.

> 2. Why does this change add server.close() to each and every test method of
> WebSocketTest? If I'm not mistaken that's what @AfterTest public void cleanup()
> is supposed to do.

I think @AfterTest does not do what you think it does.

@AfterTest: The annotated method will be run after all the test methods
belonging to the classes inside the <test> tag have run.

Really, these tests should use try-with-resources, but I wanted avoid
obfuscating the changes. That can be done separately.

-Chris.