[PATCH] JDK-8217705 - HTTPClient wrong exception type when bad status line is received

Jaikiran Pai jai.forums2013 at gmail.com
Wed Jun 12 15:01:57 UTC 2019


Hi Daniel,

On 12/06/19 7:30 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> On 12/06/2019 13:41, Jaikiran Pai wrote:
>> I decided to give it a try and host it on cr.openjdk.java.net. I have
>> now published the webrev for this patch, here
>> http://cr.openjdk.java.net/~jpai/8217705/00/webrev/
>>
>> This is my first usage of this tool, so if there's something that I
>> missed or got wrong, please do let me know. And of course, if the webrev
>> needs to be regenerated after you are done testing the patch, I can do
>> that too.
>
> Thanks for that!
>
> Since you're an author - you also don't need the
> Contributed-by: <email> line.
> This is only needed when there are several contributors,
> or when the contributor is not an author.

Fixed - removed it in the new webrev.


>
> If you have configured your ~/.hgrc as shown in [4]
> then your openjdk user id should appear in the commit
> (the user: field you can see when you do `hg log -r <rev>`)
> I believe you can also pass `--user jpai` to `hg commit`
> if not.
>
Sorry, missed that previously. Fixed this too.

The new webrev is now available for review at
http://cr.openjdk.java.net/~jpai/8217705/01/webrev/

-Jaikiran

>
> Hope this helps,
>
> -- daniel
>
> > > [4] http://openjdk.java.net/guide/producingChangeset.html


More information about the net-dev mailing list