RFR [14] 8225583: Examine the HttpResponse.BodySubscribers for null handling

Daniel Fuchs daniel.fuchs at oracle.com
Thu Jun 13 17:27:40 UTC 2019


On 13/06/2019 18:04, Pavel Rappo wrote:
>> On 13 Jun 2019, at 17:57, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>>
>> I'd prefer to remove:
>> 958             Objects.requireNonNull(throwable);
> 
> But it seems to be the crux of that change. The tests accompanying this change
> verifies that behavior.

That line is not needed since the check is made and the NPE are already
thrown (in signalError()).

Leaving it in signalError() makes it possible to print the additional
information from the assert statement before checking for null.

cheers,

-- daniel



More information about the net-dev mailing list