[PATCH] JDK-8217705 - HTTPClient wrong exception type when bad status line is received

[Jaikiran Pai]

Hello Daniel,

On 13/06/19 7:11 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> On 12/06/2019 16:01, Jaikiran Pai wrote:
>> The new webrev is now available for review at
>> http://cr.openjdk.java.net/~jpai/8217705/01/webrev/
>
> I'm happy to report that tests have been successful.
Good to hear and thank you for running these tests.
>
> Can you regenerate the webrev so that it has a changeset
> that can be hg imported? I suspect you were using mq...
> You'd have to commit the patch as if you were going to
> push it (don't forget to add 'dfuchs' to the Reviewed-by)
> and call webrev again.
> Then you can rollback the changes.
>
> hg pull -u
> hg commit -l <comment-file> [files...]
> webrev

I had followed the same process previously too. However, I think I
figured out why webrev generated it in a different format than the easy
to "import" changeset. It's got to do with the way I use my local jdk
repo - I have more than one "heads" on the default branch (almost one
each for different experimental fixes etc...), so webrev's ability to
generate the webrev using the "hg out" doesn't seem to work here. So to
get past that, previously, I had used the -N option and that seems to
generate the output in this form.

I have now hg stripped all the other heads on default branch (I wasn't
working on them any more anyway) and that way my "hg out" now shows just
one outgoing changeset and webrev too seems to be happy with it (without
the necessity of a -N).

Long story short, I think I have managed to get this right, this time.
The updated webrev is here
http://cr.openjdk.java.net/~jpai/webrev/8217705/02/webrev/. No code
changes, just commit message updates and regeneration of the webrev.
Please do let me know if this still isn't in the expected form and I'll
get this sorted out. Thanks for your help so far.

-Jaikiran


> hg rollback
>
> best regards,
>
> -- daniel