[teststabilization] RFR: 8226514: Replace wildcard address with loopback or local host in tests - part 17
Daniel Fuchs
daniel.fuchs at oracle.com
Fri Jun 28 10:08:50 UTC 2019
All good catches Chris!
New webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8226514/webrev.01
-- daniel
On 27/06/2019 10:52, Chris Hegarty wrote:
> Mainly looks good, just a few comments:
>
> 1) java/net/HttpURLConnection/SetAuthenticator/HTTPTest.java
>
> Not sure why a switch is used here with a single non-default case. It
> might be simpler to do something like
> `if (authType != PROXY) return null; ...`
>
> 2) sun/net/www/http/HttpClient/RetryPost.java
> sun/net/www/protocol/http/B6296310.java
>
> Maybe allow the IOException to just propagate up ( without catching ) .
>
> 3) sun/net/www/protocol/http/B5017051.java
>
> Maybe allow the IOException to just propagate up ( without catching ) .
> Can we remove the loooong fully qualified name?
> com.sun.net.httpserver.HttpServer
More information about the net-dev
mailing list