RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Daniel Fuchs daniel.fuchs at oracle.com
Tue Mar 12 10:45:39 UTC 2019


Hi Arthur,

This looks good to me. I have launched the changes in your second
webrev through our test system and not observed any regression.
I don't know if Chris still has some tests running, but from
my standpoint you're good to go!

best regards,

-- daniel

On 11/03/2019 18:14, Arthur Eubanks wrote:
> Updated copyright years (I asked around, it should be fine), updated 
> commit message.
> http://cr.openjdk.java.net/~aeubanks/8220083/webrev.01
> 
> On Mon, Mar 11, 2019 at 10:46 AM Martin Buchholz <martinrb at google.com 
> <mailto:martinrb at google.com>> wrote:
> 
>     These changes are clean progress and allow tests to pass on any of
>     the 4 (!) combinations of IPV4/IPV6 support available.  LGTM.
> 
>     BUT ... in the current multi-protocol world it's probably better to
>     test against all the interfaces available on the host machine.
>     Maybe there should be a InetAddress.getLoopbackAddresses (note the
>     plural!) and tests should run against all the InetAddress objects
>     returned by such an API?
>     But this is a big task (mostly spec work I would guess) for the
>     net-dev team.
> 
>     On Mon, Mar 11, 2019 at 9:55 AM Arthur Eubanks <aeubanks at google.com
>     <mailto:aeubanks at google.com>> wrote:
> 
>         bug: https://bugs.openjdk.java.net/browse/JDK-8220083
>         webrev: http://cr.openjdk.java.net/~aeubanks/8220083/webrev.00/
> 
>         First of a few ipv6 patches to come.
> 



More information about the net-dev mailing list