RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests
Chris Hegarty
chris.hegarty at oracle.com
Tue Mar 12 17:34:45 UTC 2019
Arthur,
> On 12 Mar 2019, at 16:59, Arthur Eubanks <aeubanks at google.com> wrote:
>
> Thanks for creating the umbrella bug.
>
> Split long line.
> Added the HTTPTestServer.java and UrgentDataTest.java changes in Chris's suggestions.
Thanks.
> The other 2 involve URI/URLs, and there are a lot of those changes, will group them in a later change.
That is true, and it is absolutely fine to leave them until a follow on.
The reason I suggested the change is because almost all of the other
HTTP Client tests run successfully on an IPv6-only environment. The
reason is that the URL-string when converted to a URI has the square
brackets added by URI.create. Anyway, not critical for now.
> PTAL: http://cr.openjdk.java.net/~aeubanks/8220083/webrev.02/ <http://cr.openjdk.java.net/~aeubanks/8220083/webrev.02/>
Looks good.
You are probably all set, but if you need a sponsor just ask.
-Chris.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190312/facf1d25/attachment.html>
More information about the net-dev
mailing list