[teststabilization] RFR: 8223465: Replace wildcard address with loopback or local host in tests - part 3
Daniel Fuchs
daniel.fuchs at oracle.com
Fri May 10 10:19:11 UTC 2019
Hi Aleksei,
ServerSocket_accept.java:
I think the new logic deserve a comment before line 63.
Something like:
// if readyToClose is still false it means some other
// process on the system attempted to connect: just
// ignore it, and go back to accept again.
SocksV4Test.java:
can you remove the extraneous space at line 59, and add the missing
space after '(0,' at line 60?
ChunkedErrorStream.java:
missing space at line 153. This test now uses the external
address instead of using the loopback but I guess that's OK.
Otherwise looks good!
best regards,
-- daniel
On 09/05/2019 19:42, Aleks Efimov wrote:
> Hi,
>
> Please help to review another part of test fixes to address intermittent
> failures.
>
> Webrev:
> http://cr.openjdk.java.net/~aefimov/8223465/00/
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8223465
>
> With Best Regards,
> Aleksei
More information about the net-dev
mailing list