[ipv6] RFR: 8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported

Chris Hegarty chris.hegarty at oracle.com
Sat May 11 10:48:00 UTC 2019


Arthur,

> On 10 May 2019, at 17:37, Arthur Eubanks <aeubanks at google.com> wrote:
> 
> Sounds good.
> New webrev: http://cr.openjdk.java.net/~aeubanks/8223532/webrev.03/ <http://cr.openjdk.java.net/~aeubanks/8223532/webrev.03/>
> 
> This is almost exactly the changes we made internally to this file.

Good that we eventually converged on the same substantive solution.
Bad that we went in a little circle first ( though it does give an 
additional level of confidence that we ended up in a similar place).

I think that this latest webrev looks good. I’ll do some testing with
it and report back the results.

BTW I’ m happy to drop this TODO-like comment from the code.
     // return partial list if an exception occurs in the middle of process ???
I disagree with returning a partial list. I think it just hides potential bugs.     

-Chris.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190511/0afeb5c0/attachment.html>


More information about the net-dev mailing list