[ipv6] RFR: 8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported
Arthur Eubanks
aeubanks at google.com
Wed May 15 15:19:19 UTC 2019
*From: *Chris Hegarty <chris.hegarty at oracle.com>
*Date: *Tue, May 14, 2019 at 2:44 AM
*To: *Arthur Eubanks
*Cc: *OpenJDK Network Dev list
Arthur,
>
> On 11 May 2019, at 11:48, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>
> Arthur,
>
> On 10 May 2019, at 17:37, Arthur Eubanks <aeubanks at google.com> wrote:
>
> Sounds good.
> New webrev: http://cr.openjdk.java.net/~aeubanks/8223532/webrev.03/
>
> This is almost exactly the changes we made internally to this file.
>
>
> Good that we eventually converged on the same substantive solution.
> Bad that we went in a little circle first ( though it does give an
> additional level of confidence that we ended up in a similar place).
>
> I think that this latest webrev looks good. I’ll do some testing with
> it and report back the results.
>
>
> All good. I see no issues when running various tests.
>
> -Chris.
>
> Thanks, still need one more reviewer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190515/ccc82777/attachment.html>
More information about the net-dev
mailing list