RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

[Ao Qi]

Hi Serguei,

I saw your email [1], but I didn't receive it yet. Thanks for your
review! I updated:

http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/

On Thu, May 16, 2019 at 8:30 PM David Holmes <david.holmes at oracle.com> wrote:
>
> What compiler was used here? We shouldn't be using anything that doesn't
> handle loop variable declarations!

The compiler I used is gcc 4.8.5. This machine is used for testing
jdk/jdk for months. As far as I remember, loop variable declarations
issue never been found. If gcc 4.8.5 is not a supported compiler, I
think we should update building doc [2].

>
> Thanks,
> David
>
> On 16/05/2019 7:41 pm, Daniel Fuchs wrote:
> > Hi Ao Qi,
> >
> > I'm adding serviceability-dev, since this is for jdwp.
> >
> > The proposed changes look good to me - but please get
> > someone from the serviceability team to review this.

Thanks Daniel!

Cheers,
Ao Qi

[1] https://mail.openjdk.java.net/pipermail/serviceability-dev/2019-May/028097.html
[2] https://hg.openjdk.java.net/jdk/jdk/raw-file/17926213de55/doc/building.html#gcc


> >
> > best regards,
> >
> > -- daniel
> >
> >
> > On 16/05/2019 08:41, Ao Qi wrote:
> >> Hi,
> >>
> >> I found build is failed on CentOS 7.6, because of loop initial
> >> declarations. Could I please get reviews for this?
> >>
> >> Bug:
> >> https://bugs.openjdk.java.net/browse/JDK-8224028
> >>
> >> Webrev:
> >> http://cr.openjdk.java.net/~aoqi/8224028/webrev.00/
> >>
> >> Tested:
> >> linux-x86_64-server-release tier1
> >>
> >> Thanks,
> >> Ao Qi
> >>
> >