[ipv6]: 8224019: test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java assumes IPv4 is always available

[Arthur Eubanks]

On Thu, May 16, 2019 at 11:41 PM Alan Bateman <Alan.Bateman at oracle.com>
wrote:

> On 16/05/2019 23:38, Arthur Eubanks wrote:
> > I've added testing exceptions to IPv6 as well, PTAL.
> > This required hardcoding IPv4 and IPv6 loopback addresses for the IPv4
> > and IPv6 code paths. Else DatagramChannel.join() fails since you can't
> > mix IPv4 and IPv6 addresses, and InetAddress.getLocalHost() can only
> > be one of those.
> >
> > http://cr.openjdk.java.net/~aeubanks/8224019/webrev.01/
> >
> Adding back nio-dev as it seems to have been dropped from thread again.
>
> On webrev.01, I think the approach looks okay but would you have
> re-ordering the parameters to both membershipKeyTests and exceptionTests
> so that the protocol family is first, then the groups, then the
> NetworkInterface as that will align with the usages and the join methods
> where the order is always group, networkInterface (and optionally source).
>
> -Alan
>
Done, order is protocol family, group/notGroup InetAddress,
NetworkInterface, source InetAddress
http://cr.openjdk.java.net/~aeubanks/8224019/webrev.02/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190517/1e5a5eca/attachment.html>