[teststabilization] RFR: 8224035 : Replace wildcard address with loopback or local host in tests - part 9

Aleks Efimov aleksej.efimov at oracle.com
Thu May 23 17:19:08 UTC 2019


Hi Daniel,

Thank you for the review.

I've tried to avoid 3-args constructor and/or long lines as you suggested:
http://cr.openjdk.java.net/~aefimov/8224035/01/index.html

Best,
Aleksei

On 23/05/2019 15:18, Daniel Fuchs wrote:
> Hi Aleks,
>
> Looks good to me.
>
> If possible please avoid long lines.
> Sometimes a convenient way to do that is to create
> a server socket without any arguments and then bind it.
> This has the additional advantage of avoiding the 3-args
> constructor which Alan doesn't like ;-)
>
> best regards,
>
> -- daniel
>
> On 23/05/2019 15:01, Aleks Efimov wrote:
>> Hi,
>>
>> Please help to review another part of test fixes to address 
>> intermittent networking failures:
>> http://cr.openjdk.java.net/~aefimov/8224035/00
>>
>> JBS:
>> https://bugs.openjdk.java.net/browse/JDK-8224035
>>
>> With Best Regards,
>> Aleksei
>



More information about the net-dev mailing list