[teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

[Daniel Fuchs]

Hi Vyom,

On 24/05/2019 14:36, Vyom Tiwari wrote:
> Hi Daniel,
> Overall changes looks good to me, please update the copy write date that 
> you missed in couple of files.

Which files did I miss?

> In "TestHttpServer.java"  we are printing 
> error message on System.err and throwing the RuntimeException both as 
> below, do you think we need both ?
> 
>   System.err.println ("Server could not start: " + e);
> + throw new RuntimeException("Server could not start: " + e, e);

Yes - if we don't throw the test will fail in timeout instead.
I prefer to fail fast. The exception might be swallowed if the
server is started in an executor thread though - so let's keep
both.

best regards.

-- daniel

> 
> Thanks,
> Vyom
> 
> On Fri, May 24, 2019 at 6:33 PM Chris Hegarty <chris.hegarty at oracle.com 
> <mailto:chris.hegarty at oracle.com>> wrote:
> 
> 
>     On 22/05/2019 18:35, Daniel Fuchs wrote:
>      > Hi,
>      >
>      > Please find below a patch for the next batch of tests
>      > that have been observed failing intermittently.
>      >
>      > JBS: https://bugs.openjdk.java.net/browse/JDK-8224603
>      >
>      > webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8224603/webrev.00/
> 
>     Looks ok to me Daniel.
> 
>     -Chris.
> 
> 
> 
> -- 
> Thanks,
> Vyom