[ipv6]: 8224081: SOCKS v4 doesn't work with IPv6
Sean Mullan
sean.mullan at oracle.com
Fri May 24 20:56:12 UTC 2019
On 5/23/19 8:14 PM, Arthur Eubanks wrote:
> Ping on a review from security-dev.
>
> On Fri, May 17, 2019 at 9:53 AM Chris Hegarty <chris.hegarty at oracle.com
> <mailto:chris.hegarty at oracle.com>> wrote:
>
> Arthur,
>
>> On 17 May 2019, at 17:50, Arthur Eubanks <aeubanks at google.com
>> <mailto:aeubanks at google.com>> wrote:
>>
>> Looks good.
>>
>> Trivially, maybe amend the comment to be more explicit
>>
>> 86 // SOCKS V4 ( requires IPv4 )
>>
>> -Chris.
>>
>> Done
>> http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/
>>
>> I will wait for another review from security-dev.
>
> You have my Review ( conditional on a Reviewer for the test in the
> security area ).
It seems ok but given that this area is a bit unpredictable I would
recommend you be available/online to monitor CI results after you push
the fix in case something breaks.
--Sean
More information about the net-dev
mailing list